-
Notifications
You must be signed in to change notification settings - Fork 44
Additional Unit Tests, Refactoring, & C FFI Pointer Validation #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The clippy bug that distinst's source code uncovered yesterday was fixed today, so I'll soon submit another clippy commit. |
There is an issue that prevents the ffi workspace from being lint-checked, however
Had an installation fail on me when installing with these patches. Logs from installer: journald logs: |
@brs17 I think that issue is affecting master at the moment. Thought I had fixed it. Seems to happen at random, because something (I'm assuming Vala) is freeing some statically-initialized memory that distinst wants to reuse. Short-term, I may hand Vala a unique copy of the data so it won't also end up eating the hand that feeds it in the process. |
Looks like while it said installation failed, it actually worked. Huh, interesting, I'm going to give this pr another go. |
About to submit a commit that should fix the issue for now. |
I know what's wrong. Submitting a fix soon. |
@brs17 You should be able to try again soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a "it doesn't break stuff" viewpoint.
There should be no changes to functionality or the API made in this PR. Functionality only needs to be tested to ensure that everything still works as before. GTK installer + CLI
Closes #45