Be willing to complete in the face of emptiness #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
force-pushed
the
bugfix/completing-nothing
branch
from
8790f19 to
cc1fb06
Compare
DavisVaughan
approved these changes
May 16, 2025
jennybc
force-pushed
the
bugfix/completing-nothing
branch
2 times, most recently
from
58f15d0 to
c403fb0
Compare
jennybc
force-pushed
the
bugfix/nearest-enclosing-node
branch
from
d8670d9 to
3a473a3
Compare
jennybc
force-pushed
the
bugfix/completing-nothing
branch
from
c403fb0 to
b44d356
Compare
jennybc
force-pushed
the
bugfix/completing-nothing
branch
from
de267c7 to
7953884
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
See the last "move" in #805 (comment) for a concrete illustration of what this PR does. If the client asks for completions in any context where we aren't inside a node (i.e. we're just in the 'Program' node), we should basically send all composite completions, instead of no completions.
I've verified that the new tests fail on
mainandbugfix/nearest-enclosing-nodefor the reasons I expect.