Skip to content

Init a guide about R snippets #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 30, 2025
Merged

Init a guide about R snippets #67

merged 15 commits into from
Apr 30, 2025

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Apr 29, 2025

Part of (in fact, the last piece of) posit-dev/positron#7234

Still a bit draft-y but it would be helpful to get 👀 other than mine on it

Copy link

netlify bot commented Apr 29, 2025

Deploy Preview for positron-posit-co ready!

Name Link
🔨 Latest commit 5f9c64c
🔍 Latest deploy log https://app.netlify.com/sites/positron-posit-co/deploys/6812929a9931f8000809a211
😎 Deploy Preview https://deploy-preview-67--positron-posit-co.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thank you for working on this 🙌

r-snippets.qmd Outdated
- In the case or R, this writes an `r.json` file alongside your other Positron user sertings. It is pre-populated with an R example snippet.
![Menu with options for creating a new snippet file for Python, Quarto, or R](images/snippets-configure-language-specific-snippets.png){width=700}

*To add: some sort of coverage of the RStudio snippets that we aren't porting over. Should I actually inline them? Or point at this file of them? <https://github.com/posit-dev/ark/blob/19337a1b41e8c5a3a77ac61db93b7c6bf6cdc8a3/crates/ark/resources/snippets/r.code-snippets>*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote against inlining them all, but instead saying they aren't all there and pointing to the file for more info. I would vote for pointing to the file on main explicitly so we don't point folks to something that will get out of date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're removing this file entirely, so pointing at a specific SHA is meant to guard against it getting out of date.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I understand now, got it. Would it make sense to point to the RStudio file where they come from? Or maybe just declare in words that not all have been ported? I don't know that pointing out what snippets used to be in Positron during our beta period but aren't now is helpful in the long term.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the RStudio file uses RStudio snippet syntax, whereas the one in ark has the snippets translated to the TextMate snippet syntax used by VS Code. So we should either point at a static copy of Ye Olde RStudio Snippets in TextMate form or just drop it.

I don't think anyone would have come to know and love these snippets via the Positron beta, but more likely via long-term RStudio use. So any interest in this, such as it might be, is probably going to hit when we come out of beta, I suspect.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would vote for not enumerating or linking to these, but that's a very mild opinion and I defer to what you are wanting to do, including linking to the SHA if you think it's more likely to help than confuse people.

@jennybc jennybc force-pushed the r-snippet-guidance branch from 1ca2fb8 to d509ecd Compare April 30, 2025 00:26
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@jennybc jennybc force-pushed the r-snippet-guidance branch 3 times, most recently from 1015188 to 8b0007a Compare April 30, 2025 03:02
@jennybc jennybc force-pushed the r-snippet-guidance branch from e5785ea to 8c5e3f3 Compare April 30, 2025 19:59
I learned a few interesting things with these experiments, but don't want to mix vale config changes with this PR
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@posit-dev posit-dev deleted a comment from github-actions bot Apr 30, 2025
@jennybc jennybc merged commit aeebe32 into main Apr 30, 2025
5 checks passed
@jennybc jennybc deleted the r-snippet-guidance branch April 30, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants