-
Notifications
You must be signed in to change notification settings - Fork 112
Rename suspend_display
->hold
, display_body
->expressify
, render.display
-> render.express
#1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2024
Closed
jcheng5
reviewed
Jan 19, 2024
|
||
|
||
class display(Renderer[None]): | ||
class express(Renderer[None]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No docstrings for this yet? (Or do they live somewhere else?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #996. It does the following:
express.suspend_display
->express.ui.hold
express.display_body
->express.expressify
render.display
->render.express
Also, for
hold
:hold()
now can only be used a context manager, and not as a decorator.with ui.hold() as x
, and then usex
later on the page to display it.Note that
suspend_display
is basically an alias forhold
, and in this PR it has lost the ability to be used as a decorator, which could break code that was using the previous (experimental) API.Example usage for
hold
:Example for
expressify
:Example for
render.express
: