Skip to content

Add fill to __all__ in ui and express.ui #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add fill to __all__ in ui and express.ui #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfe9337
Add fill to __all__ in ui and express.ui
wch Jan 24, 2024
975e8d9
Use separate imports
wch Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shiny/express/ui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
strong,
)

from ...ui import (
fill,
)

from ...ui import (
AccordionPanel,
AnimationOptions,
Expand Down Expand Up @@ -169,6 +173,8 @@
"span",
"strong",
"tags",
# Submodules
"fill",
# Imports from ...ui
"AccordionPanel",
"AnimationOptions",
Expand Down
10 changes: 8 additions & 2 deletions shiny/ui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@
tags,
)

# Expose the following modules for extended usage: ex: ui.fill.as_fill_item(x)
from . import css, fill # noqa: F401 # pyright: ignore[reportUnusedImport]
# The css module is for internal use, so we won't re-export it.
from . import css # noqa: F401 # pyright: ignore[reportUnusedImport]

# Expose the fill module for extended usage: ex: ui.fill.as_fill_item(x).
from . import fill

from ._accordion import (
AccordionPanel,
accordion,
Expand Down Expand Up @@ -346,6 +350,8 @@
"strong",
"em",
"hr",
# Submodules
"fill",
# utils
"js_eval",
)