Skip to content

bug(CI): Only update the shiny submodule when making the dev docs #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024
Merged

bug(CI): Only update the shiny submodule when making the dev docs #1417

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1fecf3
Only update the shiny submodule when making the docs
schloerke May 23, 2024
07a7682
Update step name and add make command for pulling latest for htmltools
schloerke May 23, 2024
1705aaa
Run many more steps if PR branch starts with `docs`
schloerke May 23, 2024
460ee24
Build site after building shinylive for faster shinylive feedback
schloerke May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/build-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ jobs:
cd docs
make quartodoc

- name: Build site
if: ${{ github.ref == 'refs/heads/main' || github.event_name == 'merge_group' || startsWith(github.head_ref, 'docs') }}
run: |
cd docs
make site

# =====================================================
# Shinylive
# =====================================================
Expand All @@ -62,19 +56,32 @@ jobs:
ref: main
path: shinylive-repo

- name: Update shinylive's copy of shiny, htmltools, and other packages
- name: Update shinylive's copy of shiny and htmltools
if: github.ref == 'refs/heads/main'
run: |
cd shinylive-repo
make submodules
make submodules-pull
make submodules-pull-shiny
make submodules-pull-htmltools

- name: Build shinylive
if: github.ref == 'refs/heads/main'
run: |
cd shinylive-repo
make all

# TODO-future; Install updated shinylive assets via updated py-shinylive pkg

# =====================================================
# Build site
# =====================================================

- name: Build site
if: ${{ github.ref == 'refs/heads/main' || github.event_name == 'merge_group' || startsWith(github.head_ref, 'docs') }}
run: |
cd docs
make site

# =====================================================
# Deploy
# =====================================================
Expand Down