Skip to content

Conversation

cpsievert
Copy link
Collaborator

No description provided.

@cpsievert cpsievert marked this pull request as ready for review August 27, 2024 23:52
@cpsievert cpsievert changed the title Install setuptools before building wheel Fix CI install failures on Windows Aug 27, 2024
@cpsievert cpsievert force-pushed the ci-win-install-failure-debug branch from 3b5b587 to 97c184e Compare August 28, 2024 00:00
@cpsievert cpsievert force-pushed the ci-win-install-failure-debug branch 4 times, most recently from 4c1b6df to 98b8724 Compare August 28, 2024 00:28
@cpsievert cpsievert force-pushed the ci-win-install-failure-debug branch from 98b8724 to 60638fd Compare August 28, 2024 00:30
@schloerke
Copy link
Collaborator

Failures (random chat tests) are unrelated to code changes made.

Merging as PR goal has been achieved.

@schloerke schloerke merged commit 6ba4cdd into main Aug 28, 2024
47 of 48 checks passed
@schloerke schloerke deleted the ci-win-install-failure-debug branch August 28, 2024 02:40
schloerke added a commit to machow/py-shiny that referenced this pull request Sep 5, 2024
* main:
  CI(deploy): Add more installation configs to surface failure cause (posit-dev#1658)
  `Chat.messages()` no longer trims messages by default (posit-dev#1657)
  tests(controllers): Split _controls.py into separate files (posit-dev#1652)
  Chat tweaks (posit-dev#1607)
  docs: Add modal_show/remove examples (posit-dev#1628)
  Delay sending of chat UI messages until reactive graph is flushed (posit-dev#1593)
  ci(remove future behavior warning): Set the `asyncio_default_fixture_loop_scope` to `fixture` (posit-dev#1655)
  bug: Verify mypy can run on CI (posit-dev#1650)
  Fix CI install failures on Windows (posit-dev#1651)
  Quartodoc 0.7.6 (posit-dev#1636)
  Allow `@chat.transform_assistant_response` function to return `None` (posit-dev#1641)
  feat: Support templates with `_template.json` metadata (posit-dev#1631)
  Fix KeyError when serving static files (posit-dev#1648)
  tests(navsets): Add navsets kitchensink tests (posit-dev#1602)
  Change default claude model to 3.5 sonnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants