Add more information about tokenizers package #1656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,9 @@ def get_default_tokenizer() -> TokenizersTokenizer | None: | |||
| except ImportError: | |||
| warnings.warn( | |||
| "`Chat` is unable obtain a default tokenizer without the `tokenizers` " | |||
| "package installed. Please `pip install tokenizers` or set " | |||
| "package installed. The tokenizer to use for calculating token counts, " | |||
| "which is required to impose `token_limits` in `.messages()`.\n" | |||
There was a problem hiding this comment.
Could the message hint at why I would want to impose token limits? Assume I don't know anything about LLMs or what makes them faster/better/cheaper.
| "package installed. Please `pip install tokenizers` or set " | ||
| "package installed. The tokenizer to use for calculating token counts, " | ||
| "which is required to impose `token_limits` in `.messages()`.\n" | ||
| "Please run `pip install tokenizers` or set " | ||
| "`Chat(tokenizer=None)` to disable tokenization.", |
There was a problem hiding this comment.
So when I see this message, my app is still working fine. So I'm guessing that it is falling back to None automatically? Would it be more accurate to say "set None to stop seeing this warning"?
|
Some notes from a discussion with @cpsievert:
|
1 task
|
#1657 supersedes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more information about why the tokenizer package should be installed for the Chat component.