docs: docstring for core shiny.modules.ui and shiny.module.server #1974
+98
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Apr 14, 2025
cpsievert
reviewed
Apr 14, 2025
cpsievert
reviewed
Apr 15, 2025
chendaniely
force-pushed
the
api-docs-module-ui-server
branch
from
d8a9b94 to
328de17
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cpsievert
reviewed
Apr 22, 2025
cpsievert
reviewed
Apr 22, 2025
cpsievert
reviewed
Apr 22, 2025
chendaniely
force-pushed
the
api-docs-module-ui-server
branch
from
a861b72 to
c86a827
Compare
|
things should be fixed now. Part of the issue was using the variable: return type notation when type hints were already defined for the function. I think that was the cause of the rendering issue
|
cpsievert
reviewed
Apr 25, 2025
cpsievert
reviewed
Apr 25, 2025
cpsievert
reviewed
Apr 25, 2025
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
|
Needed the changes from 94a9024 to get the links to show correctly
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing docstrings for
shiny.module