Minor Refactoring of re-used code and server stat reporting #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Aug 18, 2022
| if !server.in_transaction() { | ||
| self.stats.transaction(self.process_id, address.id); | ||
|
|
||
| // Release server back to the pool if we are in transaction mode. | ||
| // If we are in session mode, we keep the server until the client disconnects. | ||
| if self.transaction_mode { | ||
| self.stats.server_idle(server.process_id(), address.id); |
There was a problem hiding this comment.
Idle in transaction would be a cool state to add to our stats some day.
There was a problem hiding this comment.
yeah I originally had some confusion about this metric. I thought it was reporting the state of server connections internally. But it seems like the way pgbouncer is doing it, is it's actually determining which connections are checked out, or no checked out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the loop of sending and receiving in the 'Q' and 'S' packets into a function to reduce same code.
Sets server to active on checkout and moves setting server idle to end of loop before it is dropped