Md5 auth #55
Closed
Md5 auth #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left to figure out: Whats the right format to store user:pw in userlist? hashmap errors? actually do hash:x comparison
levkk
reviewed
Mar 4, 2022
| md5.update(salt.to_be_bytes().to_vec()); | ||
|
|
||
|
|
||
| let password_string: String = String::from_utf8(password_hash).expect("Could not get password hash"); |
There was a problem hiding this comment.
This is a panic, return an error instead.
There was a problem hiding this comment.
Better yet, use String::from_utf8_lossy which always returns successfully.
levkk
reviewed
Mar 4, 2022
| } | ||
| }; | ||
|
|
||
| let map: HashMap<String, String> = serde_json::from_str(&contents).expect("JSON was not well-formatted"); |
There was a problem hiding this comment.
This is a panic, return an error instead.
levkk
reviewed
Mar 4, 2022
| @@ -94,6 +95,15 @@ async fn main() { | |||
| } | |||
| }; | |||
|
|
|||
| // Prepare user list | |||
| match userlist::parse("userlist.json").await { | |||
There was a problem hiding this comment.
You can make this typed. Checkout the example in config.rs where we used TOML. The structure of the config file can be typed with a struct, so when you parse it you can detect errors & also you won't have to check for them when you use the config elsewhere in the code.
|
Implemented in #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left to figure out:
Whats the right format to store user:pw in userlist?
hashmap errors?
actually do hash comparison