Create Show Pages With Form #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Aug 22, 2024
Comment on lines
+8
to
+9
| rescue ActiveRecord::RecordNotFound | ||
| redirect_to vendors_path, alert: "Sweet not found" |
There was a problem hiding this comment.
This is fine, but not something we really NEED to do.
| class VendorSweetsController < ApplicationController | ||
| def create | ||
| @vendor = Vendor.find(vendor_sweet_params[:vendor_id]) | ||
| @vendor_sweet = @vendor.vendor_sweets.build(vendor_sweet_params) |
There was a problem hiding this comment.
Although this works, you don't need to use build here since vendor_id is already included in the params.
| if @vendor_sweet.save | ||
| redirect_to vendor_path(@vendor) | ||
| else | ||
| render 'vendors/show' |
There was a problem hiding this comment.
Be consistent with the quotes you're using. Try to always use double quotes:
Suggested change
| render 'vendors/show' | |
| render "vendors/show" |
| <h2>Vendors Selling This Sweet</h2><br> | ||
| <ul> | ||
| <% @sweet.vendors.each do |vendor| %> | ||
| <li> <%= link_to vendor.name, vendor_path(vendor) %></li> |
There was a problem hiding this comment.
Suggested change
| <li> <%= link_to vendor.name, vendor_path(vendor) %></li> | |
| <li><%= link_to vendor.name, vendor_path(vendor) %></li> |
Comment on lines
+11
to
+13
| <% @vendor.vendor_sweets.each do |vs| %> | ||
| <li> <%= vs.comment %></li> | ||
| <% end %> |
There was a problem hiding this comment.
Don't be lazy!
Suggested change
| <% @vendor.vendor_sweets.each do |vs| %> | |
| <li> <%= vs.comment %></li> | |
| <% end %> | |
| <% @vendor.vendor_sweets.each do |vendor_sweet| %> | |
| <li> <%= vendor_sweet.comment %></li> | |
| <% end %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a index and show page for two models (Vendor and Sweets). Pages had links that redirected to show pages per instructions. Vendor show pages has a form to create new associations with a sweet. The sweet will display on page and form requires a comment.
