Skip to content

Conversation

sineplusx
Copy link
Contributor

Discussed in ppy/osu#28243

This PR removes the UserIdentifier from log headers, along with the field itself.

I also looked into the possibility of setting the UserIdentifier from game code. For osu!, this would be using the account username when logged in. I found this unpractical as it depends on the user being authenticated before the header (and subsequently, the first log line) is written.

To my knowledge, no consuming projects use this field to set a custom username.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting one more team approval.

@smoogipoo smoogipoo requested a review from a team May 30, 2024 06:01
@peppy peppy merged commit 980b4cd into ppy:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants