CBMC: Add the spec and proof for crypto_sign_verify_internal #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the signature of poly_sub to take only 2 arguments. - Adjust polyveck_sub and all call sites accordingly. - Update CBMC proofs to reflect these changes. Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
cbmc-crypto_sign_verify_internal
branch
from
31282cd to
2006d6c
Compare
- For polyveck_use_hint, introduce new polyveck w2 and use that as the first parameter in the calling function sign.c Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
cbmc-crypto_sign_verify_internal
branch
from
d353e15 to
62381eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR created.
Still working on the crypto_sign_verify_internal CBMC contract and loop invariants.
Update polyvec_use_hint with introduce new polyveck w2 object in the calling function sign.c
Related to PR #287
Resolve issue #276