Strengthen contracts on polyvec_matrix_pointwise_montgomery() and dependents #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e this constant from MONTGOMERY_REDUCE_RANGE_MAX. 2. Similarly, and for consistency, REDUCE_DOMAIN_MAX is renamed to REDUCE32_DOMAIN_MAX 3. Strengthen post-conditions and loop invariants of the following functions montgomery_reduce() polyvecl_pointwise_acc_montgomery() polyvec_matrix_pointwise_montgomery() Signed-off-by: Rod Chapman <[email protected]>
jakemas
approved these changes
May 27, 2025
|
Can we think this a bit further so we don't have to touch it again? polyvec_matrix_pointwise_montgomery(&w1, mat, &z);
polyveck_pointwise_poly_montgomery(&t1, &cp, &t1);
polyveck_sub(&w1, &t1);
polyveck_reduce(&w1);This needs an even stricter post-condition on polyvec_matrix_pointwise_montgomery to not overflow the subtraction. |
|
I will take a look, but there will be some latency - I am at a big meeting away from home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Rename
REDUCE_RANGE_MAXtoREDUCE32_RANGE_MAXto help differentiate this constant fromMONTGOMERY_REDUCE_RANGE_MAX.Similarly, and for consistency,
REDUCE_DOMAIN_MAXis renamed toREDUCE32_DOMAIN_MAXStrengthen post-conditions and loop invariants of the following functions