CBMC: Remove convoluted implementation of 2D bounds check #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous issue in CBMC diffblue/cbmc#8570 had forced to break bounds assertions over a 2D array into nested bounds assertions. This issue has since been fixed, allowing for the simplification of the respective assertions, which is what this commit does. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
cbmc_bound_2d
branch
from
5ddafc4 to
cea4d7c
Compare
|
Causing problems with CBMC, and not a priority. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous issue in CBMC
diffblue/cbmc#8570
had forced to break bounds assertions over a 2D array into nested bounds assertions.
This issue has since been fixed, allowing for the simplification of the respective assertions, which is what this commit does.