Skip to content

Commit 8d13924

Browse files
authored
add Open in Xcode for macOS (flutter#6791)
I (hopefully) added an option "Open in Xcode". Does anyone else maybe have a test environment ready? I will test locally, opening PR to get feedback on the design question. **Design Question:** I did not add a second action, using "flutter.xcode.open" for iOS and macOS, should it rather be refactored to use two different actions? Something like ["flutter.xcode.openiOS" and "flutter.xcode.openMacOS"] or ["flutter.xcode.open.iOS" and "flutter.xcode.open.macOS"] or something else? [Missing open MacOS module in xcode flutter#6209](flutter#6209) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 1ab755c commit 8d13924

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,4 @@ Pedro Massango <[email protected]>
2323
Wagner Silvestre <[email protected]>
2424
Eli Albert <[email protected]>
2525
Mohamed El Sayed <[email protected]>
26+
Edwin Ludik <[email protected]>

flutter-idea/src/io/flutter/editor/NativeEditorNotificationProvider.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ private static String getActionName(VirtualFile root) {
7575
else if (root.getName().equals("ios")) {
7676
return "flutter.xcode.open";
7777
}
78+
else if (root.getName().equals("macos")) {
79+
return "flutter.xcode.open";
80+
}
7881
else {
7982
return null;
8083
}

resources/META-INF/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@
109109
text="Open Android module in Android Studio"
110110
description="Launch Android Studio to edit the Android module as a top-level project"/>
111111
<action id="flutter.xcode.open" class="io.flutter.actions.OpenInXcodeAction"
112-
text="Open iOS module in Xcode"
112+
text="Open iOS/macOS module in Xcode"
113113
description="Launch Xcode to edit the iOS module as a top-level project"/>
114114
<action id="flutter.appcode.open" class="io.flutter.actions.OpenInAppCodeAction"
115115
text="Open iOS module in AppCode"

resources/META-INF/plugin_template.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
text="Open Android module in Android Studio"
108108
description="Launch Android Studio to edit the Android module as a top-level project"/>
109109
<action id="flutter.xcode.open" class="io.flutter.actions.OpenInXcodeAction"
110-
text="Open iOS module in Xcode"
110+
text="Open iOS/macOS module in Xcode"
111111
description="Launch Xcode to edit the iOS module as a top-level project"/>
112112
<action id="flutter.appcode.open" class="io.flutter.actions.OpenInAppCodeAction"
113113
text="Open iOS module in AppCode"

0 commit comments

Comments
 (0)