Skip to content

build(deps): update clap requirement from 3.0.7 to 4.0.7 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build(deps): update clap requirement from 3.0.7 to 4.0.7 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ce35b4
build(deps): update clap requirement from 3.0.7 to 4.0.7
dependabot[bot] Oct 1, 2022
08f3d83
skia-org: Port to clap 4
pragmatrix Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skia-org/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ offscreen_gl_context = { git = "https://github.com/rust-skia/rust-offscreen-rend
# sparkle 0.1.9 fails to compile on macOS targeting aarch64-linux-android
# sparkle 0.1.25 is incompatible with offscreen_gl_context
sparkle = { version = "=0.1.24", optional = true }
clap = { version = "3.0.7", features = ["derive"] }
clap = { version = "4.0.7", features = ["derive"] }
ash = { version = "0.37.0", optional = true }
# need to rename the package because of the feature with the same name.
metal-rs = { package = "metal", version = "0.23.0", optional = true }
Expand Down
4 changes: 2 additions & 2 deletions skia-org/src/drivers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use clap::ArgEnum;
use clap::ValueEnum;
use skia_safe::Canvas;
use std::{fmt::Display, path::Path, str::FromStr};

Expand Down Expand Up @@ -42,7 +42,7 @@ pub trait DrawingDriver {
}
}

#[derive(Copy, Clone, PartialEq, Eq, Debug, ArgEnum)]
#[derive(Copy, Clone, PartialEq, Eq, Debug, ValueEnum)]
pub enum Driver {
Cpu,
Pdf,
Expand Down
2 changes: 1 addition & 1 deletion skia-org/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ struct Arguments {
out_path: PathBuf,
#[clap(
long,
arg_enum,
value_enum,
help = "In addition with the CPU, render with the given driver."
)]
driver: Vec<Driver>,
Expand Down