Skip to content

Compile error using strictNullChecks: true on branch v2.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkoyamaRS opened this issue Jul 11, 2019 · 1 comment
Closed

Compile error using strictNullChecks: true on branch v2.0 #17

mkoyamaRS opened this issue Jul 11, 2019 · 1 comment

Comments

@mkoyamaRS
Copy link

Tried to use the alpha version in a project with the following tsconfig compile option
"strictNullChecks": true gives the following error

/node_modules/react-diff-viewer/lib/styles.d.ts
(3,5): Property 'diffContainer' of type 'string | undefined' is not assignable to string index type 'string'.

I did have a solution by changing the index signature of ReactDiffViewerStyles to [key: string]: string | undefined; - after changing this it compiles fine with the option.

@praneshr
Copy link
Owner

I feel it's okay to turn off the strictNullChecks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants