Skip to content

Expand links get squished when line numbers are hidden, in unified (non-split) mode #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarkSiedle opened this issue Jan 9, 2020 · 3 comments
Assignees
Labels
3.1.0 Features/fixes to be added in v3.1.0 bug Something isn't working

Comments

@MarkSiedle
Copy link

Firstly thanks for this great library, amazing work :)

I believe there's a minor UI issue when using unified (non-split) view and hiding line numbers, where the expand links end up squished over to the right, like this:

2020-01-09 13_15_53-Audit - Octopus Deploy

The combination to get this to occur is as follows:

return <ReactDiffViewer ... splitView={false} hideLineNumbers={true} />;
@praneshr praneshr self-assigned this Jan 9, 2020
@praneshr praneshr added the bug Something isn't working label Jan 9, 2020
@praneshr
Copy link
Owner

Hi @MarkSiedle, thanks for reporting this bug. I'll take a look.

@praneshr praneshr added the 3.1.0 Features/fixes to be added in v3.1.0 label Jan 12, 2020
@praneshr
Copy link
Owner

Will be fixed when #61 is merged.

@praneshr
Copy link
Owner

Fixed in v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.0 Features/fixes to be added in v3.1.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants