fix(601): Fix unified view without line numbers expand cell bug #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneshr
added
3.1.0
praneshr
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will fix #60, where a unified view with no line numbers needs to have the same expand button / empty cell ordering as the other views. The original ternary was a bit confusing to me so I updated it to use
<React.Fragment />and what I think is a clearer pattern. Definitely open to feedback on that! I also needed to replicate this exception for the code-gutter class being added. See screenshots for how it all looks now on the example app.p.s. Side note / future development feature request - not sure how you feel about it, but I think it would be great to hook this repo up to https://github.com/storybookjs/storybook or something similar for easier feature development. The example page is beautiful but the changing of props is a little error prone and more difficult than it could be. :)
Screenshots:
Unified view with no line numbers before fix
All views after fix
