Skip to content

Remove engines requirement #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olee opened this issue Mar 2, 2020 · 2 comments
Closed

Remove engines requirement #69

olee opened this issue Mar 2, 2020 · 2 comments

Comments

@olee
Copy link

olee commented Mar 2, 2020

Please remove the engines requirement from package.json as there is no reason to include such an annoying field.
Or at lease make it something like { "node": ">= 8" }
olee added a commit to olee/react-diff-viewer that referenced this issue Mar 2, 2020
@olee
Fix engines requirement in package.json
d764901 
Fixes praneshr#69
@Anoian
Copy link

Anoian commented Mar 3, 2020

Yes please do this.

We use the newest node version 13 and now have to always run yarn install --ignore-engines and that really should not be the case.

@olee olee mentioned this issue Mar 4, 2020
Closed
@praneshr
Copy link
Owner

praneshr commented Mar 5, 2020

Fixed in v3.0.2

@praneshr praneshr closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix engines requirement in package.json olee/react-diff-viewer
3 participants
@olee @praneshr @Anoian