Skip to content
This repository was archived by the owner on Jan 19, 2023. It is now read-only.

Explain how to add pylint as a system hook #13

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

aleb
Copy link
Contributor

@aleb aleb commented Dec 21, 2019

As described in pre-commit/pre-commit-hooks#157
using this hook runs pylint isolated from everything else.

@aleb
Copy link
Contributor Author

aleb commented Dec 21, 2019

I see the repo name "mirrors-pylint" but is it really a mirror repo - should I do the pull request to some other origin repo?

@asottile
Copy link
Member

this doesn't really make sense here I'm afraid since your example doesn't utilize this repository at all

this is (fwiw) already documented on https://pre-commit.com (^F pylint)

@aleb
Copy link
Contributor Author

aleb commented Dec 21, 2019

If you search pylint in https://pre-commit.com/hooks.html, you get here. It might not be the best place, but it's useful. Should I leave only the warning and a generic link to https://pre-commit.com/#repository-local-hooks for "the alternative"?

@asottile
Copy link
Member

yes that seems better

As described in pre-commit/pre-commit-hooks#157
using this hook runs pylint isolated from everything else.
@aleb
Copy link
Contributor Author

aleb commented Jan 8, 2020

Looks ok?

@asottile asottile merged commit e6712de into pre-commit:master Jan 8, 2020
@asottile
Copy link
Member

asottile commented Jan 8, 2020

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants