Copy static/root to root folder with build #865 #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
requested changes
Aug 9, 2019
developit
reviewed
Aug 9, 2019
packages/cli/tests/build.test.js
Outdated
| it('should copy resources from static/root to root directory', async () => { | ||
| let dir = await subject('static-root'); | ||
| await build(dir); | ||
| let file = join(dir, '.htaccess'); |
There was a problem hiding this comment.
Static root files should still be placed into the build output directory:
Suggested change
| let file = join(dir, '.htaccess'); | |
| let file = join(dir, 'build', '.htaccess'); |
prateekbh
reviewed
Aug 9, 2019
harshitkumar31
changed the title
|
Implementation LGTM. Can someone take a look if |
|
Yeah, probably not myb |
prateekbh
approved these changes
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature - #865
Fixes #865
Did you add tests for your changes?
Yes
Summary
Copies the files from static/root directory to the project root.
Does this PR introduce a breaking change?
No
Other information
Please paste the results of
preact infohere.cc: @prateekbh