Skip to content

Remove lifecycles from core #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented May 24, 2025

Checking out the byte size impact of removing these lifecycles, we can remove componentWillUpdate as well due to #4760. 53b is a lower impact than I had expected, what do we think about this one?

Copy link

github-actions bot commented May 24, 2025

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

@JoviDeCroock JoviDeCroock force-pushed the remove-lifecycles-core branch from 4cbe3fa to 259dfe0 Compare May 24, 2025 09:36
Copy link

github-actions bot commented May 24, 2025

Size Change: -120 B (-0.26%)

Total Size: 46.4 kB

Filename Size Change
dist/preact.js 4.6 kB -44 B (-0.95%)
dist/preact.mjs 4.62 kB -39 B (-0.84%)
dist/preact.umd.js 4.68 kB -37 B (-0.78%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.73 kB
compat/dist/compat.mjs 3.65 kB
compat/dist/compat.umd.js 3.79 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.umd.js 3.94 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.mjs 1.54 kB
hooks/dist/hooks.umd.js 1.59 kB
jsx-runtime/dist/jsxRuntime.js 861 B
jsx-runtime/dist/jsxRuntime.mjs 830 B
jsx-runtime/dist/jsxRuntime.umd.js 934 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the remove-lifecycles-core branch 2 times, most recently from ce917e1 to 230e39a Compare May 29, 2025 14:05
@JoviDeCroock
Copy link
Member Author

Going to close this for the time being as the win is small but we might want to revisit this

@JoviDeCroock JoviDeCroock deleted the remove-lifecycles-core branch May 29, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant