-
Notifications
You must be signed in to change notification settings - Fork 220
Add a warning for when targeting attributes are truncated #4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AntoxaAntoxic
wants to merge
2
commits into
master
Choose a base branch
from
targeting-truncating-keys-message
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Sep 15, 2025
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
Comment on lines
267
to
296
private Map<String, String> truncateKeys(Map<String, String> keyValues, | ||
Map<String, List<ExtBidderError>> bidWarnings) { | ||
|
||
if (truncateAttrChars > 0) { | ||
final List<String> truncatedKeys = new ArrayList<>(); | ||
final Map<String, String> keys = keyValues.entrySet().stream().collect(Collectors.toMap( | ||
keyValue -> truncateKey(keyValue.getKey(), truncatedKeys), | ||
Map.Entry::getValue, | ||
(key1, key2) -> key1)); | ||
|
||
if (!truncatedKeys.isEmpty()) { | ||
final String errorMessage = "The following keys have been truncated: %s" | ||
.formatted(String.join(", ", truncatedKeys)); | ||
bidWarnings.computeIfAbsent("targeting", ignored -> new ArrayList<>()) | ||
.add(ExtBidderError.of(BidderError.Type.bad_input.getCode(), errorMessage)); | ||
} | ||
|
||
return keys; | ||
} | ||
|
||
return keyValues; | ||
} | ||
|
||
private String truncateKey(String key) { | ||
return key.length() > truncateAttrChars | ||
? key.substring(0, truncateAttrChars) | ||
: key; | ||
private String truncateKey(String key, List<String> truncatedKeys) { | ||
if (key.length() > truncateAttrChars) { | ||
truncatedKeys.add(key); | ||
return key.substring(0, truncateAttrChars); | ||
} | ||
|
||
return key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private Map<String, String> truncateKeys(Map<String, String> keyValues,
Map<String, List<ExtBidderError>> bidWarnings) {
if (truncateAttrChars <= 0) {
return keyValues;
}
final Map<String, String> keys = new HashMap<>();
final Set<String> truncatedKeys = new HashSet<>();
for (Map.Entry<String, String> entry : keyValues.entrySet()) {
final String key = entry.getKey();
final String truncatedKey = truncateKey(key);
keys.putIfAbsent(truncatedKey, entry.getValue());
if (truncatedKey.length() != key.length()) {
truncatedKeys.add(truncatedKey);
}
}
if (!truncatedKeys.isEmpty()) {
final String errorMessage = "The following keys have been truncated: %s"
.formatted(String.join(", ", truncatedKeys));
bidWarnings.computeIfAbsent("targeting", ignored -> new ArrayList<>())
.add(ExtBidderError.of(BidderError.Type.bad_input.getCode(), errorMessage));
}
return keys;
}
private String truncateKey(String key) {
return key.length() > truncateAttrChars
? key.substring(0, truncateAttrChars)
: key;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it should be truncatedKeys.add(key);
instead of truncatedKeys.add(truncatedKey);
in order to log the original key name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check