Skip to content

refactor: migrate worker.js to worker.mjs #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

refactor: migrate worker.js to worker.mjs #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e8ef1f
fix: migrate worker.js to worker.mjs
yashtech00 May 5, 2025
d609895
fix: apply requested changes
yashtech00 May 5, 2025
9e4dc52
Create eight-hornets-approve.md
JounQin May 5, 2025
99bac6f
Update worker.mjs
JounQin May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-hornets-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-prettier": minor
---

refactor: migrate `worker.js` to `worker.mjs`
2 changes: 1 addition & 1 deletion eslint-plugin-prettier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ const eslintPluginPrettier = {
if (!prettierFormat) {
// Prettier is expensive to load, so only load it if needed.
prettierFormat = /** @type {PrettierFormat} */ (
require('synckit').createSyncFn(require.resolve('./worker'))
require('synckit').createSyncFn(require.resolve('./worker.mjs'))
);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"eslint-plugin-prettier.js",
"recommended.d.ts",
"recommended.js",
"worker.js"
"worker.mjs"
],
"keywords": [
"eslint",
Expand Down
13 changes: 2 additions & 11 deletions worker.js → worker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@
* @import {ESLint} from 'eslint'
*/

const { runAsWorker } = require('synckit');

/**
* @type {typeof Prettier}
* @import * as Prettier from 'prettier'
*/
let prettier;
import prettier from 'prettier';
import { runAsWorker } from 'synckit';

runAsWorker(
/**
Expand All @@ -38,10 +33,6 @@ runAsWorker(
},
eslintFileInfoOptions,
) => {
if (!prettier) {
prettier = await import('prettier');
}

const prettierRcOptions = usePrettierrc
? await prettier.resolveConfig(onDiskFilepath, {
editorconfig: true,
Expand Down