extend divider to parent by setting props by default on the root container (BoxWithFallback) in the PageLayout component #5967
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(BoxWithFallback) in the PageLayout component
🦋 Changeset detectedLatest commit: 87593a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dwsosa
changed the title
dwsosa
force-pushed
the
dwsosa/pageLayoutExpandDividerToParent
branch
from
19500e3 to
87593a5
Compare
joshblack
reviewed
Apr 28, 2025
Comment on lines
+112
to
+113
| display: 'flex', // Makes PageLayout a flex container | ||
| flex: 1, // Fills available space in the parent |
There was a problem hiding this comment.
Would you mind moving these styles to the PageLayoutRoot class in the CSS Modules file for this component? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4351
The PageLayout component is not opinionated about layout. By adjusting the props, it will fill its parent, and the divider will extend as expected:
BEFORE
AFTER
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist