Skip to content

Feature Enhancement - Add Find and replace command #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aferriss opened this issue Jul 28, 2020 · 9 comments · Fixed by #1552
Closed

Feature Enhancement - Add Find and replace command #1519

aferriss opened this issue Jul 28, 2020 · 9 comments · Fixed by #1552

Comments

@aferriss
Copy link

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

Hi there! I'd like to propose that a find and replace feature could be added to the editor. Currently we have a find function, as well as find next and find previous, but I think it'd be super handy to also be able to find and replace either single or all instances of a search query. This might also mean some UI changes on the find pop-up bar.

I'm hoping that since the find functionality is already built out that this wouldn't be too big a lift. Sorry if this has already been proposed, I looked around in the issues but didn't see anything. Thoughts?

@catarak
Copy link
Member

catarak commented Jul 28, 2020

Thanks for the suggestion 😸 This is built into CodeMirror (demo) so I don't think this would be too hard to implement! In fact, if you look at the code for the Search popup, some code that handles replace is commented out. The hardest part would be adding in the UI and hooking up the keyboard shortcuts.

@RadheTians
Copy link

Hello @aferriss and @catarak!!
Can I please follow up on this issue?

@catarak
Copy link
Member

catarak commented Aug 3, 2020

@RadheTians absolutely! Feel free to work on it.

@RadheTians
Copy link

Thanks for confirmation @catarak.

@SundeepChand
Copy link
Contributor

SundeepChand commented Aug 11, 2020

Hello @RadheTians! Just wanted to ask if you are working on this? If not then, I would like to do it.

@RadheTians
Copy link

Hi @SundeepChand !!
I appreciate your interest but currently I am working on it and looking for the way by which I can add code in UI. It would be great if you share your idea so that we can come up with potential pull request.

@SundeepChand
Copy link
Contributor

Sure @RadheTians, continue working on this. For the UI part, from what I've done so far, changes have to be made in Nav.jsx & Editor.jsx as well as the translations have to be defined in translations.json (under translations directory). Its extremely helpful to use "Find" as a reference.

@RadheTians
Copy link

Since my placement section is going on, therefore, I'm not able to spend time on this issue so, it's handover to you @SundeepChand.

All the very best!!

@SundeepChand
Copy link
Contributor

SundeepChand commented Aug 15, 2020

Okay @RadheTians.
All the best for your interview.

@SundeepChand SundeepChand mentioned this issue Aug 16, 2020
3 tasks
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Sep 18, 2020
SundeepChand pushed a commit to SundeepChand/p5.js-web-editor that referenced this issue Sep 26, 2020
SundeepChand pushed a commit to SundeepChand/p5.js-web-editor that referenced this issue Oct 1, 2020
SundeepChand pushed a commit to SundeepChand/p5.js-web-editor that referenced this issue Oct 7, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Oct 30, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Oct 30, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 2, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 5, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 5, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 5, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 6, 2020
catarak added a commit to SundeepChand/p5.js-web-editor that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants