Skip to content

Add Emmet integration #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewragy opened this issue Jul 30, 2020 · 7 comments · Fixed by #1761
Closed

Add Emmet integration #1522

andrewragy opened this issue Jul 30, 2020 · 7 comments · Fixed by #1761

Comments

@andrewragy
Copy link

Nature of issue?

  • New feature request

New feature details: Add Emmet integration to HTML documents

@welcome
Copy link

welcome bot commented Jul 30, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Jul 30, 2020

Thanks for the suggestion! I would be interested in adding Emmet integration—it's a nice too that if you don't know about it, it doesn't get in your way at all (and you wouldn't need to turn it off because it's confusing to newcomers), but if you do, it's really useful! Emmet has even made a CodeMirror plugin so I think this wouldn't be a ton of effort to get this working.

@catarak
Copy link
Member

catarak commented Jul 30, 2020

Open to other thoughts about Emmet!

@andrewragy
Copy link
Author

I have a question: why doesn't the editor use the monaco editor, it's newer than codemirror and has a more modern ui

@catarak
Copy link
Member

catarak commented Aug 3, 2020

The big issue is that the Monaco editor is not screen reader accessible.

@neelesh7singh
Copy link
Contributor

Thanks @catarak for stating the plugin saved a lot of googling. While going through the plugin I found one more nice feature that adds emmet-open-tag and emmet-close-tag class to the HTML tags we are inside which could be used to highlight them like this -

Should I add this feature too??

@catarak
Copy link
Member

catarak commented Sep 10, 2020

Should I add this feature too??

Sure! It seems really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants