Skip to content

Connect the <PreviewFrame /> Component #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghalestrilo opened this issue Aug 28, 2020 · 1 comment · Fixed by #1647
Closed

Connect the <PreviewFrame /> Component #1590

ghalestrilo opened this issue Aug 28, 2020 · 1 comment · Fixed by #1647

Comments

@ghalestrilo
Copy link
Collaborator

Nature of issue?

  • Refactor / Code quality

Details

The <PreviewFrame /> component needs a lot of props, some of which are very specific, which are passed by the <IDEView />. Since the component is also used in the <MobileIDEView /> (and futurely in other components, maybe), it's a good idea to make it into a React Container. This has been done to the <Editor /> component, and it helps dry up the code for the Views.
There are two ways to go about this:

  1. connect it using mapStateToProps and mapDispatchToProps
  2. Use the useSelector and useDispatch react-redux hooks.
@ZenVega
Copy link
Contributor

ZenVega commented Oct 4, 2020

Hi, I would like to give it a shot. would u assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants