Skip to content

Bottom Padding issue in Keyboard Shortcuts model #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KKVANONYMOUS opened this issue Oct 28, 2020 · 3 comments · Fixed by #1655
Closed

Bottom Padding issue in Keyboard Shortcuts model #1654

KKVANONYMOUS opened this issue Oct 28, 2020 · 3 comments · Fixed by #1655

Comments

@KKVANONYMOUS
Copy link
Contributor

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Chrome
  • Operating System: Windows 10
  • Steps to reproduce this bug:
  1. Go to Help menu
  2. Select Keyboard Shortcuts
  3. Check the bottom padding of Keyboard Shortcuts model. Also try to resize the browser size and you will see the padding issue more clearly

Screenshot (14)

@welcome
Copy link

welcome bot commented Oct 28, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@sagar-joshi
Copy link
Contributor

On adding overflow property in the overlay-body class in _overlay.scss , the keyboard shortcuts tab looks like below:

Untitled

It also changes settings tab (otherwise the same problem was with settings also)

Untitled1

Creating a PR just in case the changes look okay.

@catarak
Copy link
Member

catarak commented Oct 28, 2020

Thanks for reporting!!! I'll check out your PR @sagar-joshi 😄

catarak added a commit to sagar-joshi/p5.js-web-editor that referenced this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants