Skip to content

Adding more info to Technical Part is useful? #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koji opened this issue Nov 14, 2020 · 1 comment · Fixed by #1681
Closed

Adding more info to Technical Part is useful? #1675

koji opened this issue Nov 14, 2020 · 1 comment · Fixed by #1681
Assignees

Comments

@koji
Copy link
Contributor

koji commented Nov 14, 2020

Nature of issue?

  • Edit the document

Details about the bug:

I just finished the Japanese translation. I thought maybe adding more details could be helpful for contributors to focus on translation itself.
What do you think?

If you think this can be useful for contributors, I'm happy to open a new PR for this.

The current idea is the following.

Adding a new item to Nav.jsx

<li className="nav__dropdown-item">
              <button
                onFocus={this.handleFocusForLang}
                onBlur={this.handleBlur}
                value="ja"
                onClick={e => this.handleLangSelection(e)}
              >
                your language name in your language
              </button>
            </li>

Adding your language info to i18n.js

import your langage from data-fns/locale

import { enUS, es, ja, yourLang } from 'date-fns/locale';
export function languageKeyToDateLocale(lang) {
  const languageMap = {
    'en-US': enUS,
    'es-419': es,
    'ja': ja
    'yourLang': yourLang your imported
  };
  return languageMap[lang];
}
@catarak
Copy link
Member

catarak commented Nov 16, 2020

I think this makes sense to add to translations.md! Go ahead and update it and open a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants