Skip to content

Cannot embed example sketches #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catarak opened this issue Jun 28, 2021 · 0 comments · Fixed by #1896
Closed

Cannot embed example sketches #1893

catarak opened this issue Jun 28, 2021 · 0 comments · Fixed by #1896
Assignees
@catarak

Comments

@catarak
Copy link
Member

catarak commented Jun 28, 2021

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Chrome
  • Operating System: Mac OSX
  • Steps to reproduce this bug:
  1. Open an example, such as https://editor.p5js.org/p5/sketches/Hello_P5:_song
  2. Change the URL to https://editor.p5js.org/p5/embed/Hello_P5:_song
  3. You will see a 404 error
@catarak catarak self-assigned this Jun 28, 2021
catarak added a commit that referenced this issue Jul 9, 2021
@catarak
[#1893] Enable slug urls for embed sketches
7c7028c
@catarak catarak mentioned this issue Jul 9, 2021
Merged
3 tasks
catarak added a commit that referenced this issue Jul 9, 2021
@catarak
Merge pull request #1896 from processing/bug/embed-sketches-slug
3f42056 
[#1893] Enable slug urls for embed sketches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catarak catarak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1893] Enable slug urls for embed sketches processing/p5.js-web-editor
1 participant
@catarak