Skip to content

Error message for invalid token while email verification isn't clear #2861

@aryanas159

Description

@aryanas159
Contributor

p5.js version

1.9.0

What is your operating system?

Windows

Web browser and version

No response

Actual Behavior

If the token is invalid the error message is something went wrong.
image

Expected Behavior

The error message should be more clear and state that the token is invalid or expired.

Steps to reproduce

This behavior will probably not be visible on the main p5 js website, considering it's an enhancement from my previous pull request which has been merged so it should be visible on the develop branch.

Activity

aryanas159

aryanas159 commented on Jan 7, 2024

@aryanas159
ContributorAuthor

@lindapaiste How would you like to proceed with this?

image

Currently, we are displaying the message EmailVerificationView.InvalidState in case the token is invalid.

We could either change this message for every translation file to something more appropriate like you suggested Token is invalid or expired.

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

lindapaiste

lindapaiste commented on Jan 7, 2024

@lindapaiste
Collaborator

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

Hmm the name "InvalidTokenNull" does suggest that it was intended to be used for both null and invalid tokens, doesn't it? I'm going to see if I can dig up the issues and PR from back when this was first implemented to see what was discussed then.

added
EnhancementImprovement to an existing feature
and removed
BugError or unexpected behaviors
on Jan 10, 2024
lindapaiste

lindapaiste commented on Jan 16, 2024

@lindapaiste
Collaborator

I checked the history and we have always displayed the "something went wrong" message. This is potentially related to #1587, because we get back a more descriptive message from the server but it's not translated. PR #2898 opens up the ability to translate the message from the backend. We could also change the translation on the frontend.

aryanas159

aryanas159 commented on Jan 17, 2024

@aryanas159
ContributorAuthor

@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull message, since we already have translations for it.

poswalsameer

poswalsameer commented on Oct 14, 2024

@poswalsameer

@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull message, since we already have translations for it.

Hi, is this issue still active? I would surely like to work on this one if this is still an open one.

added a commit that references this issue on Feb 20, 2025
Harshit-7373

Harshit-7373 commented on Feb 20, 2025

@Harshit-7373
Contributor

@raclim Please Review my PR & merge the PR to close the Issue.

Harshit-7373

Harshit-7373 commented on Feb 21, 2025

@Harshit-7373
Contributor

@raclim @aryanas159 In my Pull Request , The languages for which I have updated the translations.json files are: Hindi, English (US), Korean, French, and Portuguese.

Please Review it.

Harshit-7373

Harshit-7373 commented on Feb 22, 2025

@Harshit-7373
Contributor

@raclim There was one of my pull requests that you reviewed, but I didn’t receive any response on it. Could you let me know if there are any errors or if any modifications are required?

The issue number is Where my PR was submitted was : - #3163
The Pull Requests number was :- #3336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementImprovement to an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @lindapaiste@poswalsameer@aryanas159@Harshit-7373

      Issue actions

        Error message for invalid token while email verification isn't clear · Issue #2861 · processing/p5.js-web-editor