Skip to content

Make background color take up full viewport height #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

Make background color take up full viewport height #1668

merged 1 commit into from
Nov 9, 2020

Conversation

Swapnil-2001
Copy link
Contributor

@Swapnil-2001 Swapnil-2001 commented Nov 7, 2020 •
edited
Loading

Fixes #1662

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak kindly review the change.

catarak
catarak approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a new PR and bearing with my confusion 😄

@catarak catarak merged commit 67a44bd into processing:develop Nov 9, 2020
@Swapnil-2001 Swapnil-2001 deleted the signup-styles branch December 3, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catarak catarak catarak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text in Sign Up page fades into background in dark mode
2 participants
@Swapnil-2001 @catarak