Skip to content

Modified Japanese translation #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2020
Merged

Modified Japanese translation #1670

merged 8 commits into from
Nov 13, 2020
+105 −105

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 11, 2020 •
edited by catarak
Loading

RE: #1638

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@koji
Copy link
Contributor Author

koji commented Nov 11, 2020

@micuat
@deconbatch
@takawo
@sugi2000

Updated items(JSON file) that were pointed out by Naoto HIÉDA san. The following link still has some comments on the translation. I would like to hear your thought.
Thanks!

Naoto HIÉDAさんから頂いた指摘を反映させました。
下記のリンクのコメントについて、他の方の意見を伺えればと思います。
よろしくお願いします。

https://github.com/processing/p5.js-web-editor/pull/1664/files

特に、共有 or シェアについて
Facebook, Instagram: シェア
Google, Youtube: 共有

@sugi2000
Copy link

@koji 日本語化すばらしいです。
・「共有」が一般的かなとおもいます。
・「下さい」は「ください」に統一してはいかがでしょうか。

@catarak
Copy link
Member

catarak commented Nov 11, 2020

Yay! Just remove the draft status from this PR when it's ready to be merged 😄

@koji koji marked this pull request as ready for review November 13, 2020 00:52
micuat
micuat suggested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@micuat micuat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点など、docker で実際に使用してみての感想です

translations/locales/ja/translations.json Outdated
@@ -398,7 +398,7 @@
"MessageLogin": "スケッチを保存するにはログインが必要です。ログインしてください。 ",
"Login": "ログイン",
"LoginOr": " or ",
"SignUp": "サインアップ",
"SignUp": "アカウント作成",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ログイン もしくは アカウント作成.

と表示されるので、「アカウントを作成する」のほうがきれいかもしれません

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちなみにこんな感じ

image

それとは別に、メニューの方は「アカウント作成」のままでいいと思います（あるいは「アカウントを作成」）

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アカウントを作成してくださいとかの方がUIの文言としては自然ですかね？

@micuat
Copy link
Member

micuat commented Nov 13, 2020

あと、ここは「リファレンス（英語）」としたほうがいいかも

p5.js-web-editor/translations/locales/ja/translations.json

Line 31 in df6cbff

"Reference": "リファレンス",

@catarak
Copy link
Member

catarak commented Nov 13, 2020

It's hard for me to tell if this is ready to be merged or there's still a few remaining comments from @micuat. @koji let me know?

@koji
Copy link
Contributor Author

koji commented Nov 13, 2020

@catarak
I need to update the JSON file to reflect his feedback. Once everything is done, I will let you know.
Thanks!

@micuat
Copy link
Member

micuat commented Nov 13, 2020

@catarak thanks, I think I have a member permission so once it's ready I can "approve" the pull request then you can merge it - does that sound good?

@koji
Copy link
Contributor Author

koji commented Nov 13, 2020

リファレンス（英語）
ああ、確かにそっちの方が親切ですね。

@micuat
Copy link
Member

micuat commented Nov 13, 2020

丁寧語で統一するのいいアイディアだと思います！

Looks good, should we wait for more comments or merge now? Unless there is an obvious fix, I think we should finish reviewing and if there is something to fix we can open a new issue/pr.

@koji
Copy link
Contributor Author

koji commented Nov 13, 2020

I think we can go forward.
Yeah, I agree with you. We can open a new issue/pr to fix an issue.
Anyway, thank you for your help. Really appreciate🙏

micuat
micuat approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@micuat micuat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished revision! @catarak please merge when you can :)

micuat
micuat approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@micuat micuat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i'm retrying because i might have submitted review on the wrong commit)

...so obviously I don't have permission to approve 🤣

@catarak catarak merged commit f4d8573 into processing:develop Nov 13, 2020
@catarak
Copy link
Member

catarak commented Nov 13, 2020

yay! so excited this translation is done. when i deploy this i'm gonna post about it on the p5.js twitter 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micuat micuat micuat approved these changes

@catarak catarak catarak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koji @sugi2000 @catarak @micuat