Skip to content

Fix Bad Gateway Error 502 on viewing a deleted sketch #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fix Bad Gateway Error 502 on viewing a deleted sketch #1682

merged 3 commits into from
Nov 17, 2020

Conversation

KKVANONYMOUS
Copy link
Contributor

Fixes #1676

This pull request fixes the issue of Bad Gateway Error 502 described in issue #1676.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Nov 17, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the callback value a little more explicit 😄

@catarak catarak merged commit 2ae2649 into processing:develop Nov 17, 2020
@idontknowjs
Copy link

@catarak As I could reproduce, the issue still exists. Have a look at the deleted sketch: https://editor.p5js.org/covalentbond/full/CNjP7hLts. It still shows "Bad gateway error"

@catarak
Copy link
Member

catarak commented Nov 17, 2020

@CovalentBond thanks for checking that. The production URL, https://editor.p5js.org is only updated during a release (major/minor/patch). This issue hasn't been included in a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad Gateway Error 502 on viewing a deleted sketch
3 participants