Fix PropTypes.object() linting errors #1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catarak
requested changes
Nov 24, 2020
| @@ -38,7 +38,7 @@ const ActionStrip = ({ actions }) => ( | |||
|
|
|||
| ActionStrip.propTypes = { | |||
| actions: PropTypes.arrayOf(PropTypes.shape({ | |||
| icon: PropTypes.any, | |||
| icon: PropTypes.any, //eslint-disable-line | |||
There was a problem hiding this comment.
Is there a way to fix this so that you don't have to disable linting on this line?
There was a problem hiding this comment.
@catarak I think in order to resolve it we have to explicitly specify the data type of icon field.
Can you please tell me which data type does it use?
There was a problem hiding this comment.
It should be PropTypes.component! I fixed it 😄
|
I have resolved the issue related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1514
I have replaced all the instances of
PropTypes.object.isRequiredwithPropTypes.objectOf(PropTypes.shape())in the following files:Also, while debugging those errors I encountered a linting error with
PropTypes.anyin ActionStrip.jsx which I disabled by using//eslint-disable-linefor the time being.I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123