-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enable Creation of .xml files #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release EnvironmentsLeave a comment on this Pull Request with any of the following commands:
|
create release environment |
You also need to update the translations ( |
Hello @catarak, please let me know if anything is missing in the PR. |
working great for me ✨ |
Hello Cassie (@catarak ). I don't know if I'm doing something wrong but on my side nothing has changed: cannot create, upload or rename to .xml files. For .xml and .html files I try to create I still get the following message: 'Invalid file type. Valid extensions are .js, .css, .json, .txt, .csv, .tsv, .frag, and .vert.' Trials to rename a .txt file to .xml do nothing: the .txt extension remains, without any message from editor. Uploading .html file is possible, but not .xml file ('You can't upload files of this type' message'). Does it work for you with the p5js editor on production now or with a development version that will be pushed in production later? Thanks a lot to everyone for your work on these issues! :o) Laurent PS: sketch I've used for testing is this one. Tried with Google Chrome and Firefox, cache beeing clear and editor reloaded before testing. |
@Wildernesss this is because this change has not yet been deployed to production! I'm scheduling a deploy this weekend so look out for this change very soon 😄 |
Fixes #1741
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123
Hello @catarak. I have not enabled syntax-highlighting for XML files. How can I enable that in codemirror?