Skip to content

Enable Creation of .xml files #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Conversation

SundeepChand
Copy link
Contributor

@SundeepChand SundeepChand commented Feb 2, 2021

Fixes #1741

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Hello @catarak. I have not enabled syntax-highlighting for XML files. How can I enable that in codemirror?

@release-com
Copy link

release-com bot commented Feb 2, 2021

Release Environments

Leave a comment on this Pull Request with any of the following commands:

  • create release environment - A new staging environment will be created using the code in this Pull Request

@SundeepChand
Copy link
Contributor Author

create release environment

@catarak
Copy link
Member

catarak commented Feb 2, 2021

You also need to update the translations (NewFileModal.InvalidType) to add .xml files. I think in all of the translations it's just a list of extensions so you don't need to speak that specific language.

@SundeepChand
Copy link
Contributor Author

Hello @catarak, please let me know if anything is missing in the PR.

@catarak
Copy link
Member

catarak commented Feb 16, 2021

working great for me ✨

@catarak catarak merged commit 508634d into processing:develop Feb 16, 2021
@Wildernesss
Copy link

Hello Cassie (@catarak ). I don't know if I'm doing something wrong but on my side nothing has changed: cannot create, upload or rename to .xml files. For .xml and .html files I try to create I still get the following message: 'Invalid file type. Valid extensions are .js, .css, .json, .txt, .csv, .tsv, .frag, and .vert.' Trials to rename a .txt file to .xml do nothing: the .txt extension remains, without any message from editor. Uploading .html file is possible, but not .xml file ('You can't upload files of this type' message'). Does it work for you with the p5js editor on production now or with a development version that will be pushed in production later? Thanks a lot to everyone for your work on these issues! :o)

Laurent

PS: sketch I've used for testing is this one. Tried with Google Chrome and Firefox, cache beeing clear and editor reloaded before testing.

@catarak
Copy link
Member

catarak commented Feb 17, 2021

@Wildernesss this is because this change has not yet been deployed to production! I'm scheduling a deploy this weekend so look out for this change very soon 😄

@SundeepChand SundeepChand deleted the enable-xml branch February 20, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upload or create .xml file into editor.p5js
3 participants