-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactored all HTTP requests to use axios #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored all HTTP requests to use axios #1763
Conversation
Release Environmentsp5.js-web-editor |
I can't even tell you the joy this brings me. Feels so good to clean up code! Since this is touching on some fundamental stuff I'm going to test this carefully. |
Everything seems to be working for me except for fetching the ml5 examples. However, this could be because of some necessary changes in #1762—I think I'm going to get that one merged in first, handle the git conflicts, and see if that fixes it. |
I've tested |
The
|
Fixes #975
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123
Hello @catarak, please review this. I have not been able to test
fetch-examples-ml5.js
as I could not find theEDITOR_API_ACCESS_TOKEN
.