Skip to content

Refactored all HTTP requests to use axios #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 19, 2021

Conversation

SundeepChand
Copy link
Contributor

Fixes #975

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Hello @catarak, please review this. I have not been able to test fetch-examples-ml5.js as I could not find the EDITOR_API_ACCESS_TOKEN.

@release-com
Copy link

release-com bot commented Feb 15, 2021

Release Environments

p5.js-web-editor
app-tedfbad-p5-js-web-editor.releaseapp.io

@catarak
Copy link
Member

catarak commented Feb 16, 2021

I can't even tell you the joy this brings me. Feels so good to clean up code! Since this is touching on some fundamental stuff I'm going to test this carefully.

@catarak
Copy link
Member

catarak commented Feb 16, 2021

Everything seems to be working for me except for fetching the ml5 examples. However, this could be because of some necessary changes in #1762—I think I'm going to get that one merged in first, handle the git conflicts, and see if that fixes it.

@SundeepChand
Copy link
Contributor Author

I've tested examples-ml5.js & its working for me now.

@catarak
Copy link
Member

catarak commented Feb 19, 2021

The ml5 script is also working for me! All of the other functionality this touches also is working for me:

  • p5.js example fetching script
  • generative design example fetching script
  • downloading sketches
  • using sketch assets by url
  • syntax highlighting script

@catarak catarak merged commit 9687be8 into processing:develop Feb 19, 2021
@SundeepChand SundeepChand deleted the refactor/update-to-axios branch February 20, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor all HTTP requests to use axios
2 participants