Skip to content

[#1764] Check if sketch file url is AWS S3 url #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

catarak
Copy link
Member

@catarak catarak commented Feb 16, 2021

Fixes #1764

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak catarak merged commit e25d803 into develop Feb 16, 2021
@release-com
Copy link

release-com bot commented Feb 16, 2021

Release Environments

p5.js-web-editor

@catarak catarak deleted the bug/sketch-deletion-s3 branch February 16, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when deleting sketch that contains file url not on s3
1 participant