Added new WCAG AA and AAA compliant text selection colors #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Environmentsp5.js-web-editor |
|
Working great for me! Just tested on Mac/Windows. |
catarak
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1742
Hey @catarak, I am sorry for taking too much time to fix this, I was busy with some university stuff. I have chosen the following colors:-
For Light Theme -
text color - #333333
background - #D9D9D9
For Dark and Contrast Themes -
text color - #000000
background - #FFFFFF
They are compliant with WCAG AA and AAA Standard.
Video Sample -
Highlight_Text.mp4