-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Creates Index.integration.test.jsx and Sketchlist.unit.test.jsx #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates Index.integration.test.jsx and Sketchlist.unit.test.jsx #1780
Conversation
Release Environmentsp5.js-web-editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting suggestions!
developer_docs/testing.md
Outdated
## Useful testing commands | ||
Run the whole test suite | ||
``` | ||
npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually for shell commands in documentation I preface them with a $
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed :-) thank you!
developer_docs/testing.md
Outdated
(x) => Promise.resolve({ data: 'foo' }) | ||
); | ||
``` | ||
You can see it used in the context of a test [here](../client/modules/IDE/components/SketchList.test.jsx). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For screen reader accessibility reasons, it's best practice to not have links with the text "here" or "click here", but to instead describe what the link goes to. See What's wrong with using "Click Here" links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, good to know! Thanks for letting me know~
developer_docs/testing.md
Outdated
### What to test | ||
For any type of component, you might want to consider testing: | ||
- User input results in the class's method being called. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change this line to "```js", then this code will be syntax highlighted. same with all of the other instances of code. See Creating and highlighting code blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, MAGIC! It worked and looks much better :))
Creates a few new tests, tweaks some testing helper files to work for those tests, add dev libraries msw and redux-mock-store.
Tests added:
Other files added:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123