Skip to content

Removes find next popup closing issues #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

satyasaibhushan
Copy link
Contributor

Fixes #1774

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@satyasaibhushan
Copy link
Contributor Author

Also the find is behaving a bit weird (I think it is intentional)

  1. The text is not being highlighted unless we type 2 or more letters and the number is not getting updated unless we press enter
  2. If we type a word and removed it by deleting the letters, the highlighting is getting stuck at 2 words and the highlight is not being removed.
    Please check if these are intentional or needs some fixing

@satyasaibhushan
Copy link
Contributor Author

I am attaching a video for clarificaitons

Screen.Recording.2021-03-13.at.12.21.33.AM.mov

@release-com
Copy link

release-com bot commented Mar 12, 2021

Release Environments

p5.js-web-editor
app-ted143c-p5-js-web-editor.releaseapp.io

@catarak
Copy link
Member

catarak commented Mar 18, 2021

@satyasaibhushan i think the behavior you found is okay! it's actually the default behavior for the codemirror search...

@catarak catarak merged commit 1aa6c17 into processing:develop Mar 18, 2021
@satyasaibhushan satyasaibhushan deleted the removes_find_next_popup_closing_issues branch March 18, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Find next" and "Find previous" popups glitches to close
2 participants