Skip to content

Fix colors of the errors in the console in Contrast and dark mode.(#2046) #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ayushbhaimehta
Copy link

Fixes #2046

Changes:
I have added an important tag to all the modes. After which it is looking like this in contrast mode
image
While hovering over the link will look like this
image

I have verified that this pull request:

[☑] has no linting errors (npm run lint)
[ ] has no test errors (npm run test)
[☑] is from a uniquely-named feature branch and is up to date with the develop branch.
[☑] is descriptively named and links to an issue number, i.e. Fixes #2046

@welcome
Copy link

welcome bot commented Jan 18, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Jan 18, 2023

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-b19c03bced

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this, and for your patience as we review these issues—I think overall this looks great!

Before it's ready to go, I think there's a few more edits that could be added:

1.) Removing the "!important" property from the lines I commented on since it seems to be affecting the color scheme of the play/pause buttons (pictured below).

How it looks right now:
Screenshot 2023-02-08 at 2 11 48 PM

Original:
Screenshot 2023-02-08 at 2 11 54 PM

2.) Re-inserting the .env.example file, which has currently been removed

Thanks again and super excited to see this out soon! :)


& g,
& path {
fill: getThemifyVariable('inactive-text-color') !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the "!important" for the path property, since it's affecting the color scheme for the play/pause button!


& g,
& path {
fill: getThemifyVariable('heavy-text-color') !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this one too!

@raclim
Copy link
Collaborator

raclim commented Mar 15, 2023

Thank you so much for your efforts on this! This was ultimately resolved by #2156, so I'm going to close this for now. :)

@raclim raclim closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Friendly error links have poor color contrast
2 participants