Added eye icon

[perminder-17]

Fixes #2466

Changes: I have made the eye icon which is very helpful. here's how it works

p5.js.Web.Editor._.Login.mp4

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[perminder-17]

Hi @lindapaiste can u please review the pull request.

[perminder-17]

@raclim @lindapaiste can this be merged or should I change something

[perminder-17]

I have tested the changes for microsoft edge too. @lindapaiste @raclim

[PiyushChandra17]

Looks good to me, also working demo seems pretty fine!

[perminder-17]

Looks good to me, also working demo seems pretty fine!

Thankyou so much.

[perminder-17]

@lindapaiste Can we merge this PR? Or shall work on it's design? if Yes, can you please tell me what kind of design should i go with?

[katiejliu]

I think this eye icon looks bette than the other "hide" "show" pull request @raclim

[raclim]

I think one issue I'm finding here is that the eye icon shifts when the error message for the form appears!

I haven't thought this through yet, but I'm wondering if it'd be better to either move the styles within the LoginForm.jsx and SignupForm.jsx file into a separate one, or to convert it into a styled-component?

[perminder-17]

Sorry for the delay, I'll git it done very soon @raclim

[perminder-17]

I will be making a commit by june 6th. And will update what's required here.

[perminder-17]

p5.js-webe.mp4

so sorry for being too late @raclim . I was busy with my university exams and GSOC work, happily I got some time to shift styles to seperate one. also fixed the issue which was arising.

[raclim]

No worries, thanks so much for getting back to this, I really appreciate it!

I made a minor adjustment to the styling of the eye icon (changed the top property from 5px to 7px), but overall I think this looks great so far! Thanks so much again for your work on this! :)

[perminder-17]

Hahahhaa no worries @raclim . I love to contribute and will surely contribute in this awesome organization with these awesome Mentainers like you❤