fix: changed-ConsoleInput-to-function-based #2487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
I don’t have time to review this right now, but have you run this on localhost and confirmed that it works when you type a line in the console? I suspect that it does not work, as your code is very similar to a previous PR that had a lot of problems. Honestly I think we are going to leave this one as a class component because it is too complicated and confusing to convert it. Please read my comments on #2409. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2358
Changes: Converted legacy React class component to function component (ConsoleInput component)
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123