Update p5.sound toggle behaviour

[davepagurek]

Fixes #3513

Changes:

• Changing the p5 version now always does something to p5.sound:
  • If you switched from 1.x to 2.x or vice versa, it turns off p5.sound
  • If you switch minor 1.x versions, it updates p5.sound to use the URL associated with that version
  • No action for minor 2.x version switches, as p5.sound releases are no longer tied to p5 releases
• Removes the behaviour of trying to remember your last p5.sound version
• Always shows a link next to the p5.sound toggle with a link to either beta.p5js.org/reference/p5.sound or p5js.org/reference/p5.sound

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[ksen0]

@davepagurek Would it be possible to use latest within 1.x? Since we are still bugfixing for a while.

[davepagurek]

Updated this to use currentP5Version. I also updated the default web editor version to 1.11.8, since it was still 1.11.7 elsewhere. @raclim ideally we use the same string and splice it into createDefaultFiles.js so we have less places to update when there's a new version, as currently the two were out of date. Looks like that file is run on the server? Is there a spot for anything currently that gets imported in both client and server that I could move that constant to?

[raclim]

I...don't believe that it exists yet. I'm sorry I think it might have to be created!

[davepagurek]

No problem! I'm happy to create that. Would something like a top-level common folder be ok?

[raclim]

Yes, that sounds good to me! Thank you so much!

[davepagurek]

ok I think I've added that! i added a thing to the dockerfile about the common folder, which seems to work running the project via docker, but I'm less confident that that's correct or necessary, so let me know if that seems ok to you!

[raclim]

Yes I think its correct, thanks so much for catching that I completely forgot about it! The folder setup/Dockerfile looks good to me! :)

[raclim]

This overall looks great to me!!! This is small question—I noticed that if I have a new sketch, switch to 2.x, and then back to 1.x, it seems like p5.sound is still turned off. I was wondering if this is intentional, or something that we might want to address here as well?

[davepagurek]

This overall looks great to me!!! This is small question—I noticed that if I have a new sketch, switch to 2.x, and then back to 1.x, it seems like p5.sound is still turned off. I was wondering if this is intentional, or something that we might want to address here as well?

Currently intentional, but we can talk about what we'd need to do if we want that! Our previous "remembering" logic was intended to try to capture the specific p5.sound URL that was being used, but that prevented you from switching to 2.0 and then turning on the 2.0 version of p5.sound. We could possibly do something where we have separate memory for 1.x and 2.x, and only try to restore when you go back and forth between them? That could possibly be a memory of a specific version like before (downside being, it's harder to switch between 1.x versions and update p5.sound accordingly), or just on/off and we pick the corresponding version for you (downside being, it may not correspond to the version you used to be using, especially if you revert to a different 1.x than you started with.)