Removed linter warnings #820
Conversation
Signed-off-by: shiva <[email protected]>
Signed-off-by: shiva <[email protected]>
|
@ksen0 could you review the PR when you find the time? |
| @@ -0,0 +1,6 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
There was a problem hiding this comment.
It's a helpful PR to fix the linter warnings.
But I'm wondering, is husky required?
There was a problem hiding this comment.
I agree, In the original discussion #771 I was suggesting removing existing linter warnings as a prerequisite for considering something like husky
There was a problem hiding this comment.
Hi @shivasankaran18 , thanks a lot of these changes look really helpful! One minor question in the review; and could you please remove the updates to packages / remove husky from this commit? The intent was to separately remove existing issues, then add the automations. Because the 2.0 and main branches are used to deploy to 2 different sites (p5js.org and beta.p5js.org) so this will need to also be cherrypicked into 2.0, and automations shouldn't be added until linter warnings are removed on both sites
| @@ -80,6 +57,31 @@ const SearchProvider = ({ | |||
| } | |||
|
|
|||
| if (!searchTerm) return; | |||
|
|
|||
| const flattenData = (data: FuseResult<SearchResult>) => { | |||
There was a problem hiding this comment.
Could you explain why this one had to be moved, please?
| @@ -0,0 +1,6 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
There was a problem hiding this comment.
I agree, In the original discussion #771 I was suggesting removing existing linter warnings as a prerequisite for considering something like husky
Related Issue : #771
I have removed all the linter warnings produced by the eslint .